Simplify hqadmin views by removing hqadmin_base_report.html #35504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
requested review from
millerdev,
AmitPhulera,
gherceg and
jingcheng16
orangejenny
force-pushed
the
jls/simplify-hqadmin
branch
2 times, most recently
from
b314eaa to
b93797e
Compare
orangejenny
force-pushed
the
jls/simplify-hqadmin
branch
from
b93797e to
71522f4
Compare
millerdev
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
None of the views that inherit from this template are reports. Let's just kill it.
Safety Assurance
Safety story
Surface-level changes to admin-only views. Tested locally.
Automated test coverage
Not for the views.
QA Plan
no
Rollback instructions
Labels & Review